West Midlands| May 2026 | Muhammad-Burhan Mustafa | Sprint 1 | Form Controls#1282
Closed
burhan-mustafa wants to merge 7 commits into
Closed
West Midlands| May 2026 | Muhammad-Burhan Mustafa | Sprint 1 | Form Controls#1282burhan-mustafa wants to merge 7 commits into
burhan-mustafa wants to merge 7 commits into
Conversation
created style sheet to centre the form
and size also fixed the space for minlength on line 31
for both select elements
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
burhan-mustafa
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
burhan-mustafa
changed the title
burhan-mustafa
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 18, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task - the style has a nice sharp clean design.
There are some issues in the HTML you have written, could you check and respond to my other comments, thanks
| <main> | ||
| <form> | ||
|
|
||
| <form method = "get" class = "form-container"> |
There was a problem hiding this comment.
Is there a reason you put spaces between the attribute and the value?
Author
There was a problem hiding this comment.
There is no real reason aside from just muscle memory when I type.
| <br> | ||
|
|
||
| <!-- Asks for their surname --> | ||
| <label for = "surname"> Surname: </label> |
There was a problem hiding this comment.
Be careful about requiring both a forename and a surname. Not all people have 2 names, and some have many more.
If you check the Readme it only asks for a "name" - how could you change the form to match this?
Author
There was a problem hiding this comment.
I could ask for a full name instead of a forename and surname
LonMcGregor
added
Reviewed
…d surname to replace it with full name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Self checklist
Changelist
This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size, with built-in validation to ensure all fields are required and correctly formatted.
Questions
Any improvements or suggestions on how to improve this form?